-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop matplotlib dependency #1120
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1120 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 65 65
Lines 9059 9059
=========================================
Hits 9059 9059
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Out of curiosity, shouldn't we add matplotlib somewhere as optional? I think there are some tests for the examples in CI, but they are still passing so I guess it was installed as a dependecy of another dependency?
Dropping is fine but I agree with @stavros11 that we should add it as optional. |
I don't believe it should be optional, but rather it should be in the The spirit is that:
Of course, a Qibo user might want to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me in the tests group. We could also add a sentence in the examples/README.md that some example require matplotlib
.
It is actually a dependency of the examples, but they are usually run together with the tests. For the time being it is not worth a separate group
matplotlib
seems unused inqibo
, and only used in the examples#814
Checklist: