Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBF Energy fluctuations #1080

Merged
merged 8 commits into from
Nov 13, 2023
Merged

DBF Energy fluctuations #1080

merged 8 commits into from
Nov 13, 2023

Conversation

Edoardo-Pedicillo
Copy link
Contributor

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@Edoardo-Pedicillo Edoardo-Pedicillo marked this pull request as ready for review November 7, 2023 16:51
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/qibo/models/double_bracket.py 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!

andrea-pasquale
andrea-pasquale reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Edoardo-Pedicillo for implementing this.
Generally it looks good to me. Only a small comment regarding a fix for GPU.
Moreover, feel free to add a small test so that we don't lose coverage.

src/qibo/models/double_bracket.py Outdated Show resolved Hide resolved
andrea-pasquale
andrea-pasquale reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Edoardo-Pedicillo for adding tests.
Two quick fixes for GPU.

src/qibo/models/double_bracket.py Outdated Show resolved Hide resolved
tests/test_models_dbf.py Outdated Show resolved Hide resolved
MatteoRobbiati
MatteoRobbiati approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@MatteoRobbiati MatteoRobbiati merged commit dbc8a12 into dbf Nov 13, 2023
26 checks passed
@scarrazza scarrazza deleted the dbf_exp_values branch December 4, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoRobbiati MatteoRobbiati MatteoRobbiati approved these changes

@andrea-pasquale andrea-pasquale andrea-pasquale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Edoardo-Pedicillo @andrea-pasquale @MatteoRobbiati