Remove node-fetch #196
Merged
Remove node-fetch #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-fetch is no longer going to be included with the library since all currently supported Node.js versions include a
fetchglobal. This allows for a faster install of the library, and, mainly, reduces the burden of having to update node-fetch whenever it gets a security update.Users of this library using old unsupported Node.js versions can still use the library, but need to either define a
fetchglobal (by importing node-fetch and settingglobalThis.fetch), or, if that's undesirable, set this only for the library usingrequire('megajs').API.fetchModule = require('node-fetch').