[ui][python console] Fix hard to read python console editor icons #60261
Conversation
nirvn
changed the title
nirvn
added
GUI/UX
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
Instead of the buffer (which is a little ugly), how about using parameterised colors here? QgsApplication::getThemeIcon supports that already, so we could keep the single-color icon but render it using a suitable color based on the palette |
|
@nyalldawson , done. The ugly buffer is something we rely on for quite a few icons, eg:
We can fix that one day :) |
| @@ -261,7 +261,10 @@ def contextMenuEvent(self, e): | |||
|
|
|||
| menu.addSeparator() | |||
| toggle_comment_action = QAction( | |||
| QgsApplication.getThemeIcon("console/iconCommentEditorConsole.svg"), | |||
| QgsApplication.getThemeIcon( | |||
There was a problem hiding this comment.
This icon is also used in python/plugins/processing/script/ScriptEditorDialog.py and src/gui/codeeditors/qgscodeeditor.cpp -- they'll also need the palette color set
There was a problem hiding this comment.
@nyalldawson , done, thanks.
nirvn
force-pushed
the
python_console_icons_fix
branch
from
ea47c46 to
4390742
Compare
Description
This PR fixes #59772 by altering two icons to insure their visibility is OK on both light / gray / dark themes.
Blend of gray before:
Blend of gray after:
Night mapping before:
Night mapping after:
