Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grass plugin build (followup d2078b00) #60038

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

jef-n
Copy link
Member

@jef-n jef-n commented Jan 2, 2025

No description provided.

@github-actions github-actions bot added this to the 3.42.0 milestone Jan 2, 2025
Copy link

github-actions bot commented Jan 2, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 453ea56)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 453ea56)

@jef-n jef-n requested a review from m-kuhn January 2, 2025 11:43
@m-kuhn
Copy link
Member

m-kuhn commented Jan 2, 2025

@jef-n do you still have the build error around somewhere?

@jef-n
Copy link
Member Author

jef-n commented Jan 2, 2025

@jef-n do you still have the build error around somewhere?

In file included from /usr/lib/grass84/include/grass/vect/digit.h:3,
                 from /usr/lib/grass84/include/grass/vector.h:4,
                 from /build/qgis-3.41.0+git20241231+834b94b0c01+99sid/src/providers/grass/qgsgrassvectormaplayer.h:38,
                 from /build/qgis-3.41.0+git20241231+834b94b0c01+99sid/src/providers/grass/qgsgrassvectormap.h:26,
                 from /build/qgis-3.41.0+git20241231+834b94b0c01+99sid/src/plugins/grass/qgsgrasseditrenderer.cpp:29:
/usr/lib/grass84/include/grass/vect/dig_structs.h:31:10: fatal error: libpq-fe.h: No such file or directory
   31 | #include <libpq-fe.h>
      |          ^~~~~~~~~~~~
compilation terminated.

@m-kuhn
Copy link
Member

m-kuhn commented Jan 2, 2025

This should be added to a grass target and because we don't have that to the grass provider instead.
Does it help if you add PostgreSQL::PostgreSQL here https://github.com/qgis/QGIS/blob/master/src/providers/grass/CMakeLists.txt#L135 ?

@jef-n jef-n force-pushed the fix-grass-plugin branch from 5e458a8 to 453ea56 Compare January 2, 2025 15:03
@jef-n jef-n merged commit 3c6a465 into qgis:master Jan 2, 2025
31 checks passed
@jef-n jef-n deleted the fix-grass-plugin branch January 2, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants