Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-3_40] overlay_intersects: flatten collections and filter by type #59822

Open
wants to merge 2 commits into
base: release-3_40
Choose a base branch
from
Open

[Backport release-3_40] overlay_intersects: flatten collections and filter by type #59822

wants to merge 2 commits into from

Conversation

qgis-bot
Copy link
Collaborator

Backport #59477
Authored by: @elpaso

@elpaso @github-actions
overlay_intersects: flatten collections and filter by type
b8f8250 
Partial fix for #59408

- try to merge multilinestrings to get the max length
- consider the tested geomery type when intersection is a collection

Funded by: Body & Soul ♬
@elpaso @github-actions
clang-format
f400f6c
@github-actions github-actions bot added this to the 3.40.2 milestone Dec 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit f400f6c)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit f400f6c)

@github-actions GitHub Actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Dec 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this Jan 7, 2025
@agiudiceandrea agiudiceandrea reopened this Jan 7, 2025
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 7, 2025
@agiudiceandrea agiudiceandrea requested a review from elpaso January 7, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbruy alexbruy alexbruy approved these changes

@elpaso elpaso Awaiting requested review from elpaso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.40.2
Development

Successfully merging this pull request may close these issues.
4 participants
@qgis-bot @alexbruy @agiudiceandrea @elpaso