Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak build on FreeBSD after qtermwidgets update #52679

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

rhurlin
Copy link
Contributor

@rhurlin rhurlin commented Apr 13, 2023

Description

After qtermwidgets has been updated in the GRASS provider, the build on FreeBSD is broken with the following error:

.../src/plugins/grass/qtermwidgets/kpty.cpp:98:11:fatal error:'utmp.h' file not found.

The patch circumstances this 'classic' utempter problem for FreeBSD.

After qtermwidgets has been updated in the GRASS provider, the build on FreeBSD is broken with the following error:

.../src/plugins/grass/qtermwidgets/kpty.cpp:98:11:fatal error:'utmp.h' file not found.

The patch circumstances this 'classic' utempter problem on FreeBSD.
@github-actions github-actions bot added this to the 3.32.0 milestone Apr 13, 2023
@nyalldawson
Copy link
Collaborator

Can you submit this upstream too please?

@rhurlin
Copy link
Contributor Author

rhurlin commented Apr 13, 2023

Can you submit this upstream too please?

Thanks for this very fast approval :)

I am afraid I have not write access to this repository. Loïc Bartoletti offered to do this for me.

@nyalldawson
Copy link
Collaborator

By upstream I mean a pr at https://github.com/lxqt/qtermwidget

I'll merge this one after the ci finishes its run.

@nyalldawson nyalldawson merged commit cc094fb into qgis:master Apr 13, 2023
@rhurlin
Copy link
Contributor Author

rhurlin commented Apr 14, 2023

By upstream I mean a pr at https://github.com/lxqt/qtermwidget

Ah ok, I had misunderstood that.

In the meantime, I contacted our FreeBSD maintainer for the KDE ports about the qtermwidgets patch. He's a good judge of whether this FreeBSD-specific patch is otherwise relevant enough to be committed upstream.

I'll merge this one after the ci finishes its run.

Thanks for the merge :)

@rhurlin
Copy link
Contributor Author

rhurlin commented Apr 15, 2023

Can you submit this upstream too please?

I just opened pull request qtermwidget #503 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants