Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Étienne Trimaille <[email protected]>
  • Loading branch information
rldhont and Gustry authored Feb 3, 2023
1 parent 1c2f1e3 commit f64941b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion src/server/services/wms/qgswmsgetcapabilities.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1018,7 +1018,7 @@ namespace QgsWms

handleLayersFromTreeGroup( doc, layerElem, serverIface, project, request, treeGroupChild, wmsLayerInfos, projectSettings );

// CHeck if child layer elements have been added
// Check if child layer elements have been added
if ( layerElem.elementsByTagName( QStringLiteral( "Layer" ) ).length() == 0 )
{
continue;
Expand Down
2 changes: 0 additions & 2 deletions tests/src/python/test_qgsserver_accesscontrol_wms.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ def test_wms_getcapabilities(self):
str(response).find("<Name>Country</Name>") != -1,
f"Unexpected Country layer in GetCapabilities\n{response}")

# This test hasn't run yet
# @unittest.expectedFailure
def test_wms_getprojectsettings(self):
query_string = "&".join(["%s=%s" % i for i in list({
"MAP": urllib.parse.quote(self.projectPath),
Expand Down

0 comments on commit f64941b

Please sign in to comment.