Fix nested prefetches in qdrant_local.py #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local qdrant client with nested prefetches raised the exception: none type has no attribute query. This little change fixes it
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@hh-space-invader thanks for taking over! Will you bring this to the finish line or do you expect some more work from me :) ? |
|
hi @paul2302 thank you for your contribution, we'll finish it and merge soon on our own |
joein
reviewed
Sep 13, 2024
joein
approved these changes
Sep 13, 2024
|
@joein thank you for taking over so quickly. Is there a timeline for when this might be part of the next release? |
|
Hey, I expect it to be released not later than 2 days |
|
@joein so quickly? Wow, thanks! Keep up the great work :D |
joein
added a commit
that referenced
this pull request
Sep 16, 2024
* Fix nested prefetches in qdrant_local.py Local qdrant client with nested prefetches raised the exception: none type has no attribute query. This little change fixes it * chore: Added the check for prefetch to async * fix: Fix nested prefetch in async local mode by generating the async client * chore: Added a test case for query using nested prefetch in congruence tests * remove redundant version check --------- Co-authored-by: hh-space-invader <[email protected]> Co-authored-by: George <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having multiple nested prefetches does not seem to work with qdrant in local mode. The last prefetch in the chain is none which then raises an exception in the _resolve_prefetch_input method:
if prefetch.queryraises an exception since prefetch is none)
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
pre-commitwithpip3 install pre-commitand set up hooks withpre-commit install?Changes to Core Features: