Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make datetime range conditions tz aware #538

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Conversation

joein
Copy link
Member

@joein joein commented Mar 12, 2024

No description provided.

@joein joein requested review from coszio and Anush008 March 12, 2024 22:17
Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit 6b0c51c
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/65f0e1264df8dd0008f06f33
😎 Deploy Preview https://deploy-preview-538--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joein joein changed the title fix: do not set tz if it is not provided in local mode fix: make datetime range conditions tz aware Mar 12, 2024
Copy link
Member

@Anush008 Anush008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @joein.

@Anush008 Anush008 linked an issue Mar 13, 2024 that may be closed by this pull request
@joein joein merged commit 848c63c into dev Mar 13, 2024
14 checks passed
@Anush008 Anush008 deleted the fix-naive-and-aware-dt-local branch March 15, 2024 04:41
joein added a commit that referenced this pull request Mar 27, 2024
* fix: do not set tz if it is not provided in local mode

* refactor: remove commented out code

* fix: rollback tzinfo, add tzinfo to conditions in local mode

* fix: slightly increase chance of datetime payload generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datetime inconsistency between Qdrant local and remote
3 participants