new: deprecate upload records, update tests, prohibit migration of co… #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
generall
reviewed
Jan 19, 2024
qdrant_client/qdrant_client.py
Outdated
| max_retries=max_retries, | ||
| wait=wait, | ||
| shard_key_selector=shard_key_selector, | ||
| **kwargs, |
There was a problem hiding this comment.
if kwargs is empty, let's not pass it here
generall
reviewed
Jan 19, 2024
generall
reviewed
Jan 19, 2024
generall
approved these changes
Jan 19, 2024
…llections with custom shards
joein
force-pushed
the
deprecate-upload-records
branch
from
f2c7814 to
319bd1b
Compare
joein
added a commit
that referenced
this pull request
Jan 19, 2024
#447) * new: deprecate upload records, update tests, prohibit migration of collections with custom shards * Update qdrant_client/qdrant_client.py * Update qdrant_client/async_qdrant_client.py * new: replace autogenerated int ids with uuids (#448) * fix: remove redundant kwargs * fix: regen async * fix: remove redundant import --------- Co-authored-by: Andrey Vasnetsov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upload_recordsdue to the deprecation ofmodels.Record.models.Recordwas deprecated due to ashard_keywhich can't be specified item-by-item in uploading processes Replace types.Record in upload_records with Points #427