fix: fix portalocker being deleted before closing the client #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
generall
reviewed
Jan 5, 2024
qdrant_client/local/qdrant_local.py
Outdated
Comment on lines
67
to
70
| except ( | ||
| TypeError | ||
| ): # sometimes portalocker module can be garbage collected before QdrantLocal instance | ||
| pass |
generall
approved these changes
Jan 5, 2024
joein
added a commit
that referenced
this pull request
Jan 19, 2024
* fix: fix portalocker being deleted before closing the client * fix: generate async, update comment * update formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes portalocker module being deleted even before deletion of QdrantLocal
In this case when
__del__method in QdrantClient being called, we can already don't have portalocker object and calling unlock on it will cause an errorNoneType...#365