-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async qdrant client #319
Merged
Merged
Async qdrant client #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joein
force-pushed
the
async-qdrant-client
branch
from
October 13, 2023 05:27
ddfa661
to
e72ed0f
Compare
update ci to fail if async client was updated |
generall
approved these changes
Oct 13, 2023
generall
pushed a commit
that referenced
this pull request
Oct 16, 2023
* new: manually implemented async qdrant client * fix: remove await before sync call * fix: make upload collection, records and migrate synchronous * fix: add init method to async client base * refactoring: remove redundant import * new: add super().__init__ in qdrant remote, update import in http * new: mvp async qdrant client generator * new: fix mypy, update generator script, refactoring * fix: fix test script * new: update generator launch script, update async files * new: refactor async client generator * refactoring: remove redundant operations, add comments, refactor * new: add isort, black and autoflake to dev dependencies * fix: add more checks, fix type hints * fix: do not check types in async client generator for python3.8 * new: do not type check async_qdrant_fastembed * fix: fix pyright run * new: update async client tests * fix: update versions in CI * new: update pre-commit python version, update autogenerated files * new: update generated files, add tests for async generator, update generator script * fix: exclude generator test from 3.8 * fix: fix python version condition * fix: add python target version for black * fix: generate async client only on python 3.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is an mvp of async qdrant client generator
It should be refactored a lot, it is a minimal code to produce a workable client