Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add case-sensitive toggle for Find/Replace #924

Closed
ghost opened this issue Jun 18, 2019 · 3 comments
Closed

Add case-sensitive toggle for Find/Replace #924

ghost opened this issue Jun 18, 2019 · 3 comments
Labels
est:Minor Minor effort to implement est:Score=3 Score for estimate of effort required (scale of 1 upwards) support:Approved Approved to be done under the support agreement support This issue is a candidate to complete under the support agreement
Milestone
Support release

Comments

@ghost
Copy link

ghost commented Jun 18, 2019

Following work on #705, keeping Find and Replace consistent, it may be beneficial to allow the user to toggle this behaviour.
When this work begins, both find and replace will be case insensitive. One of the reasons for this is that there is support for 'diacritics' built in (important for other language use), which use library that hardcodes various glyphs/characters to our regular English alphabet. Trying to split this out into what should/would be lowercase or uppercase is subjective (e.g., pick which one of these you would deem as uppercase 'I' or lowercase 'i' or something else entirely: ḭƗɨɨ̆ᵻᶖİiIıɪ )
While I don't think case sensitivity will solve the problem just listed, a user will at least be able to just distinguish between 'lowercase' and 'uppercase' in regular alphabet. Mucking around with what diacritics would or wouldn't be supported by such a toggle, say in a user preference, would be out of scope for this ticket.
@ghost ghost added est:Minor Minor effort to implement est:Score=3 Score for estimate of effort required (scale of 1 upwards) support This issue is a candidate to complete under the support agreement labels Jun 18, 2019
@ghost ghost added this to the Support release milestone Jun 18, 2019
@Stephen-Gates
Copy link
Contributor

Sounds reasonable for this support release @mattRedBox.

@markwheels suggest this is labelled support:Approved and prioritised above #902.

@markwheels markwheels added the support:Approved Approved to be done under the support agreement label Jun 19, 2019
@markwheels
Copy link

Thanks @mattRedBox and @Stephen-Gates. I have marked this issue 'support:Approved'.

@ghost ghost closed this as completed in 18ea670 Jun 30, 2019
ghost pushed a commit that referenced this issue Jun 30, 2019
Closes #206: Ensure locked, not toggled for import. Add Tab behaviour…
20b15fe 
… to lock. Separated logic from main's url to frictionless for easier re-use. Added submenu items for both file and url. Improved style to suit open. Allowed title to change. Closes #742. Closes #731. Added Import Column Properties to file disable/enable list. Closes #924: Enabled difference between case-insensitive (with diacritics) and case-sensitive (without diacritics).

Signed-off-by: Matthew Mulholland <[email protected]>
ghost pushed a commit that referenced this issue Jun 30, 2019
Closes #206: Ensure locked, not toggled for import. Add Tab behaviour…
c1fcce4 
… to lock. Separated logic from main's url to frictionless for easier re-use. Added submenu items for both file and url. Improved style to suit open. Allowed title to change. Closes #742. Closes #731. Added Import Column Properties to file disable/enable list. Closes #924: Enabled difference between case-insensitive (with diacritics) and case-sensitive (without diacritics).
@Stephen-Gates
Copy link
Contributor

Confirmed working in 1.1 beta

ghost pushed a commit that referenced this issue Apr 21, 2021
Closes #206: Ensure locked, not toggled for import. Add Tab behaviour…
22d1c26 
… to lock. Separated logic from main's url to frictionless for easier re-use. Added submenu items for both file and url. Improved style to suit open. Allowed title to change. Closes #742. Closes #731. Added Import Column Properties to file disable/enable list. Closes #924: Enabled difference between case-insensitive (with diacritics) and case-sensitive (without diacritics).
ghost pushed a commit that referenced this issue Apr 21, 2021
Closes #206: Ensure locked, not toggled for import. Add Tab behaviour…
1c5e9c4 
… to lock. Separated logic from main's url to frictionless for easier re-use. Added submenu items for both file and url. Improved style to suit open. Allowed title to change. Closes #742. Closes #731. Added Import Column Properties to file disable/enable list. Closes #924: Enabled difference between case-insensitive (with diacritics) and case-sensitive (without diacritics).

Signed-off-by: Matthew Mulholland <[email protected]>
ghost pushed a commit that referenced this issue Apr 21, 2021
Closes #206: Ensure locked, not toggled for import. Add Tab behaviour…
15f8e2c 
… to lock. Separated logic from main's url to frictionless for easier re-use. Added submenu items for both file and url. Improved style to suit open. Allowed title to change. Closes #742. Closes #731. Added Import Column Properties to file disable/enable list. Closes #924: Enabled difference between case-insensitive (with diacritics) and case-sensitive (without diacritics).
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
est:Minor Minor effort to implement est:Score=3 Score for estimate of effort required (scale of 1 upwards) support:Approved Approved to be done under the support agreement support This issue is a candidate to complete under the support agreement
Projects
None yet
Milestone
Support release
Development

No branches or pull requests
2 participants
@Stephen-Gates @markwheels