Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Data Package Error on Windows only #804

Closed
louisjasek opened this issue May 24, 2018 · 6 comments
Closed

Open Data Package Error on Windows only #804

louisjasek opened this issue May 24, 2018 · 6 comments
Labels
env:Windows This issue is related to running Data Curator on Windows fn:Open-Data priority:High problem:Bug A bug
Milestone

Comments

@louisjasek
Copy link

Current Behaviour (for problems)

When I open this data package (https://github.com/frictionlessdata/example-data-packages/raw/master/zip/cpi.zip) from URL on Windows, it spits out an error message. This does not occur when I open the same data package from URL on mac.

open data package error

Expected Behaviour

When opening this data package, no error should occur and the data package should open correctly

Steps to Reproduce

  1. Open Data Curator using the icon
  2. Click File > Open Data Package > Zip from URL
    3.Enter this URL: https://github.com/frictionlessdata/example-data-packages/raw/master/zip/cpi.zip
  3. Click Open URL
  4. Error appears.

Your Environment

Data Curator version: 0.17.0
Operating System and version: Windows 10 Pro

@louisjasek
Copy link
Author

@Stephen-Gates if you wouldn't mind adding priority and milestone to this one too. Again I feel this is high priority given it is against core functionality. It seems to be loading some of the package (e.g. the data) but not all of it. If it was just an error message but everything worked it wouldn't be as high priority. Keen on your thoughts though.

@Stephen-Gates Stephen-Gates added this to the v0.18.0 milestone May 24, 2018
@Stephen-Gates Stephen-Gates added env:Windows This issue is related to running Data Curator on Windows problem:Bug A bug fn:Open-Data priority:High labels May 24, 2018
@louisjasek
Copy link
Author

This is occurring when opening data package from file as well. For example if you were to download that file to your desktop and then open from file from data curator.

@Stephen-Gates
Copy link
Contributor

Stephen-Gates commented May 29, 2018

edit Explore upgrading to the latest version of HandsOnTable (moved to 805)

@ghost
Copy link

ghost commented May 31, 2018

nothing to do with handsontable - think that comment is meant for #805

@ghost
Copy link

ghost commented May 31, 2018

error in path creation - will make this os-dependent.

ghost pushed a commit that referenced this issue Jun 3, 2018
…eam error handling. Corrected logic for multiple ignores.
@ghost ghost closed this as completed in 55e87e7 Jun 3, 2018
ghost pushed a commit that referenced this issue Jul 5, 2018
@ghost
Copy link

ghost commented Jul 11, 2018

Hi @louisjasek
The issue you raised (with mixing path separators) was resolved. However, I noticed that I was a little overzealous with replacing the Unix path separator with OS-dependent call - so I re-coded to ensure that datapackage.json always records as Unix path as mentioned in spec - this now also is resolved.
I think a tidy-up of the bottom status bar, following the 'fix heading' issue was also warranted - so have gone ahead with this as well.

image

image

@ghost ghost reopened this Jul 11, 2018
@ghost ghost closed this as completed in fb89aa9 Jul 11, 2018
ghost pushed a commit that referenced this issue Apr 21, 2021
…eam error handling. Corrected logic for multiple ignores.
ghost pushed a commit that referenced this issue Apr 21, 2021
ghost pushed a commit that referenced this issue Apr 21, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
env:Windows This issue is related to running Data Curator on Windows fn:Open-Data priority:High problem:Bug A bug
Projects
None yet
Development

No branches or pull requests

2 participants