Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guess Column Properties - Ignore Missing Values? #107

Closed
Stephen-Gates opened this issue Sep 27, 2017 · 3 comments
Closed

Guess Column Properties - Ignore Missing Values? #107

Stephen-Gates opened this issue Sep 27, 2017 · 3 comments
Labels
env:MacOS This issue is related to running Data Curator on macOS env:Windows This issue is related to running Data Curator on Windows fn:Guess-Properties priority:Medium problem:Bug A bug
Milestone

Comments

@Stephen-Gates
Copy link
Contributor

Stephen-Gates commented Sep 27, 2017

Expected Behaviour

When guessing column properties, ignore missing values

Current Behaviour

a column with dd/mm/yyyy or null values should be guessed to be a type: date and format: any and depending on tableschema.js capabilties perhaps guess the pattern %d/%m/%Y

screenshot 2017-09-28 00 22 57

Your Environment

  • Data Curator version 0.3.1
  • Operating System macOS Sierra 10.12.6
@Stephen-Gates Stephen-Gates added f:Question A question for project maintainers and contributors priority:Medium problem:Bug A bug and removed f:Question A question for project maintainers and contributors labels Sep 27, 2017
@Stephen-Gates Stephen-Gates added this to the v0.3.2 milestone Sep 27, 2017
@Stephen-Gates Stephen-Gates added env:MacOS This issue is related to running Data Curator on macOS env:Windows This issue is related to running Data Curator on Windows fn:Guess-Properties labels Sep 28, 2017
@Stephen-Gates
Copy link
Contributor Author

ghost pushed a commit that referenced this issue Oct 5, 2017
@ghost
Copy link

ghost commented Oct 5, 2017

Pattern not in yet, but missing values is

@ghost ghost closed this as completed Oct 5, 2017
@Stephen-Gates
Copy link
Contributor Author

Confirmed fixed on Windows 7

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
env:MacOS This issue is related to running Data Curator on macOS env:Windows This issue is related to running Data Curator on Windows fn:Guess-Properties priority:Medium problem:Bug A bug
Projects
None yet
Development

No branches or pull requests

1 participant