fix: primefaces#5060, Dropdown: After selecting an option, clearing t…

…he value using close icon should clear the filter input
qburst · Jan 15, 2024 · e1a6d4e · e1a6d4e
1 parent fa50897
commit e1a6d4e
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 1 deletion.
diff --git a/api-generator/components/dropdown.js b/api-generator/components/dropdown.js
@@ -185,6 +185,12 @@ const DropdownProps = [
         default: 'false',
         description: 'Clears the filter value when hiding the dropdown.'
     },
+    {
+        name: 'resetFilterOnClear',
+        type: 'boolean',
+        default: 'false',
+        description: 'Clears the filter value when clicking on the clear icon.'
+    },
     {
         name: 'virtualScrollerOptions',
         type: 'object',

diff --git a/components/lib/dropdown/BaseDropdown.vue b/components/lib/dropdown/BaseDropdown.vue
@@ -106,6 +106,10 @@ export default {
             type: Boolean,
             default: false
         },
+        resetFilterOnClear: {
+            type: Boolean,
+            default: false
+        },
         virtualScrollerOptions: {
             type: Object,
             default: null

diff --git a/components/lib/dropdown/Dropdown.d.ts b/components/lib/dropdown/Dropdown.d.ts
@@ -389,6 +389,11 @@ export interface DropdownProps {
      * @defaultValue false
      */
     resetFilterOnHide?: boolean;
+    /**
+     * Clears the filter value when clicking on the clear icon.
+     * @defaultValue false
+     */
+    resetFilterOnClear?: boolean;
     /**
      * Whether to use the virtualScroller feature. The properties of VirtualScroller component can be used like an object in it.
      */

diff --git a/components/lib/dropdown/Dropdown.vue b/components/lib/dropdown/Dropdown.vue
@@ -421,7 +421,7 @@ export default {
         },
         onClearClick(event) {
             this.updateModel(event, null);
-            this.filterValue = null;
+            this.resetFilterOnClear && (this.filterValue = null);
         },
         onFirstHiddenFocus(event) {
             const focusableEl = event.relatedTarget === this.$refs.focusInput ? DomHandler.getFirstFocusableElement(this.overlay, ':not([data-p-hidden-focusable="true"])') : this.$refs.focusInput;

diff --git a/doc/common/apidoc/index.json b/doc/common/apidoc/index.json
@@ -24170,6 +24170,14 @@
                             "default": "false",
                             "description": "Clears the filter value when hiding the dropdown."
                         },
+                        {
+                            "name": "resetFilterOnClear",
+                            "optional": true,
+                            "readonly": false,
+                            "type": "boolean",
+                            "default": "false",
+                            "description": "Clears the filter value when clicking on the dropdown."
+                        },
                         {
                             "name": "virtualScrollerOptions",
                             "optional": true,