Expose stop tracker timeout in Advanced Settings (GUI + WebUI)

[ghost]

Exposing the settings for stop_tracker_timeout so user can set it to higher value to ensure tracker announces go through when client is exited/torrent is paused.

[ghost]

Dear @Chocobo1 @glassez please review it. Thanks!

[FranciscoPombal]

In general:

• You should try to make sure the new code for this setting appears at roughly in the same order relative to other settings in all relevant source files. This is not the case at the moment.

  For example, in src/base/bittorrent/session.cpp, you put the new code between m_asyncIOThreads... and m_filePoolSize... but in src/base/bittorrent/session.h you put it between RefreshInterval... and PreallocationEnabled....
  It is just a matter of fixing the order.

• There are a couple of places where indentation is bad/missing.
  EDIT: it appears most of the indentation problems are due to the use to tab instead of spaces

• There are a couple of places where you named variables/function names etc with snake_case when they should have been camelCase

[sledgehammer999]

I am skeptical about the need of exposing this setting. It seems a bit unnecessary. Can't it be set to a sane default?

[FranciscoPombal]

@sledgehammer999

I am skeptical about the need of exposing this setting. It seems a bit unnecessary. Can't it be set to a sane default?

There is already ongoing discussion about whether or not the default value for this setting should change, take a look: #11807

Regardless of the final decision on that matter, I think it is already clear that there are different enough use cases that warrant this setting be configurable. It is not a one-size-fits-all.

[ghost]

In general:

• You should try to make sure the new code for this setting appears at roughly in the same order relative to other settings in all relevant source files. This is not the case at the moment.
  For example, in src/base/bittorrent/session.cpp, you put the new code between m_asyncIOThreads... and m_filePoolSize... but in src/base/bittorrent/session.h you put it between RefreshInterval... and PreallocationEnabled....
  It is just a matter of fixing the order.
• There are a couple of places where indentation is bad/missing.
  EDIT: it appears most of the indentation problems are due to the use to tab instead of spaces
• There are a couple of places where you named variables/function names etc with snake_case when they should have been camelCase

Thanks for your review. I tried to fix the mentioned issues as best as I could.

I am skeptical about the need of exposing this setting. It seems a bit unnecessary. Can't it be set to a sane default?

A sane default is necessay but this will allow user to tweak the settings to their use case.

[FranciscoPombal]

Thanks for your review. I tried to fix the mentioned issues as best as I could.

No problem. Only a few minor things left. I will post the next review shortly.

[FranciscoPombal]

You still need to move a couple of code snippets to the correct place to be 100% consistent.
Additionally, you forgot the libtorrent documentation help links in the settings (both webUI and gui).

[FranciscoPombal]

Looks good. Now you have to squash the commits before this can be merged.

[glassez]

The period shouldn't appear at the end of commit message subject (so-called commit title).

[ghost]

The period shouldn't appear at the end of commit message subject (so-called commit title).

Fixed. Should the default value remain at 1 s?

[glassez]

Should the default value remain at 1 s?

I have no strong preferences about it (if it works in general case).
If it affects application shutdown time I wouldn't increase it.
Anyway I think changing default value is separate issue.

[Chocobo1]

@An0n666
Thanks!