Allow custom line color in the charts #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuri
added
the
size/S
xuri
reviewed
Sep 13, 2022
xuri
pushed a commit
to carbin-gun/excelize
that referenced
this pull request
Oct 9, 2022
xuri
pushed a commit
to JDavidVR/excelize
that referenced
this pull request
Jul 11, 2023
jenbonzhang
pushed a commit
to jenbonzhang/excelize
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Use Series=>Line=>Color in the chart drawing.
Description
Currently, it is possible to specify Series=>Line=>Color for charts, however, this color would not affect drawing as we have a hardcoded formula for SchemeClL ""accent" + strconv.Itoa((formatSet.order+i)%6+1)}" and do not use SrgbClr field at all. I propose use SrgbClr instead of SchemeClL if Line=>Color is specified.
Related Issue
#1345
Motivation and Context
Allow user to control the line's color
How Has This Been Tested
Types of changes
Checklist