Add cache support for similar images #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qarmin
force-pushed
the
cache_similar_image
branch
from
7414535 to
9a0432d
Compare
|
|
||
| fn save_hashes_to_file(hashmap: &HashMap<String, FileEntry>, text_messages: &mut Messages) { | ||
| if let Some(proj_dirs) = ProjectDirs::from("pl", "Qarmin", "Czkawka") { | ||
| // Lin: /home/alice/.config/barapp |
There was a problem hiding this comment.
What is barapp? The ~/.config/barapp doesn't exist, even if it looks like the cache works.
There was a problem hiding this comment.
Only this comment looks wrong, the rest of the code and the cache work! 👍
There was a problem hiding this comment.
This comment was intended to show only where this function want to save data in general(comment was copied from directories-next crate).
Proper locations I put to instruction.
I have updated this comments in #196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #23 for similar images