Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider empty/blank as empty string instead of null for CSV/XML/Excel data provider and BDD examples #342

Closed
cjayswal opened this issue May 25, 2020 · 0 comments

Comments

@cjayswal
Copy link
Contributor

cjayswal commented May 25, 2020

Scenario 2:
Cannot leave a variable value empty String in the csv. It takes null and not a whitespace value which was the case earlier.

summary,file-format,with-data,amount-rows
one valid email address (XLSX),xlsx,,1

This variable is not even set for the test:
And generate 'xlsx' into file 'fileName' for '1' users and profiles with data '{${with-data}}'[0.005s ]

Report looks like this:
And generate 'xlsx' into file 'fileName' for '1' users and profiles with data '{${with-data}}'[0.005s ]
Unable to invoke JavaStep with given arguments: generateBulkUserProfileWithData[xlsx, fileName, 1, {${with-data}}]
at

Workaround:
As of now based on your implementation code, I've added \ followed by a comma at the end for every line in the csv so that we can use the older implementation code:

summary,file-format,with-data,amount-rows
one valid email address (XLSX),xlsx,,1,,

This was working fine in 2.14-RC1

This behavior is as per design with 2.1.14+ available from 2.1.14-RC3. Refer release notes from 2.1.14-RC3 Updated CSV, XML and Excel data provider to return objects instead of Strings

Originally posted by @cjayswal in #335 (comment)

@cjayswal cjayswal changed the title Scenario 2: Consider empty/blank as empty string instead of null for CSV data provider and BDD examples May 25, 2020
@cjayswal cjayswal changed the title Consider empty/blank as empty string instead of null for CSV data provider and BDD examples Consider empty/blank as empty string instead of null for CSV/XML/Excel data provider and BDD examples May 25, 2020
cjayswal added a commit that referenced this issue May 26, 2020
updated code to correct object conversion
cjayswal added a commit that referenced this issue Jan 2, 2022
- used same implementation for xls and xlsx
- removed old implementation ExcelUtil
- #342 for cell with string (Text or @) format, considering empty cell
value as empty string. Null for others including no format (General)

Related to #386, #339, #269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant