Continue using webdriver manager until selenium-manager is in beta state

qaf-tm · Jul 11, 2023 · 4792e57 · 4792e57
1 parent a959bf1
commit 4792e57
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/ivy.xml b/ivy.xml
@@ -134,8 +134,8 @@ SOFTWARE.
 		<dependency org="org.apache.commons" name="commons-jexl3" rev="3.2.1"  conf="compile->default"/>
 
 		<!-- https://mvnrepository.com/artifact/io.github.bonigarcia/webdrivermanager 
-		<dependency org="org.slf4j" name="slf4j-log4j12" rev="1.7.30"  conf="compile->default"/> 
-		<dependency org="io.github.bonigarcia" name="webdrivermanager" rev="4.4.3"  conf="compile->default"/> -->
+		<dependency org="org.slf4j" name="slf4j-log4j12" rev="1.7.30"  conf="compile->default"/>  -->
+		<dependency org="io.github.bonigarcia" name="webdrivermanager" rev="4.4.3"  conf="compile->default"/>
 
 		<!-- repo-editor -->
 		<!-- https://mvnrepository.com/artifact/org.apache.httpcomponents.core5/httpcore5 -->

diff --git a/src/com/qmetry/qaf/automation/ui/UiDriverFactory.java b/src/com/qmetry/qaf/automation/ui/UiDriverFactory.java
@@ -66,7 +66,7 @@
 import com.qmetry.qaf.automation.ui.webdriver.QAFWebDriverCommandListener;
 import com.qmetry.qaf.automation.util.StringUtil;
 
-//import io.github.bonigarcia.wdm.WebDriverManager;
+import io.github.bonigarcia.wdm.WebDriverManager;
 
 /**
  * com.qmetry.qaf.automation.ui.UiDriverFactory.java
@@ -418,7 +418,7 @@ private QAFExtendedWebDriver getDriver(WebDriverCommandLogger reporter, String u
 					return new QAFExtendedWebDriver(ChromeDriverHelper.getService().getUrl(), desiredCapabilities,
 							reporter);
 				}*/
-				//setUpDriverExecutable(driverCls);
+				setUpDriverExecutable(driverCls);
 				WebDriver driver = getDriverObj(driverCls, desiredCapabilities, urlstr);// driverCls.newInstance();
 				return new QAFExtendedWebDriver(driver, reporter);
 			} catch (Throwable e) {
@@ -429,7 +429,7 @@ private QAFExtendedWebDriver getDriver(WebDriverCommandLogger reporter, String u
 			}
 		}
 
-		/*private static void setUpDriverExecutable(Class<? extends WebDriver> driverClass) {
+		private static void setUpDriverExecutable(Class<? extends WebDriver> driverClass) {
 			try {
 				if (ConfigurationManager.getBundle().getBoolean("manage.driver.executable", true)) {
 					logger.info(
@@ -444,7 +444,7 @@ private QAFExtendedWebDriver getDriver(WebDriverCommandLogger reporter, String u
 						"Unable to setup driver executable: "+e.getMessage());
 
 			}
-		}*/
+		}
 
 		private QAFExtendedWebDriver getDriver(String url, WebDriverCommandLogger reporter) {
 			Capabilities desiredCapabilities = getDesiredCapabilities();