-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 0.13.3 release #538
Conversation
Relax space group requirement when creating phase from CIF
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
….13.1 Main into develop after 0.13.1
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Update develop after 0.13.2
updates: - [github.com/psf/black: 24.8.0 → 24.10.0](psf/black@24.8.0...24.10.0)
[pre-commit.ci] pre-commit autoupdate
Avoid expensive deepcopy when rotating Miller
Signed-off-by: Håkon Wiik Ånes <[email protected]>
…e descriptive Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
@CSSFrancis, the pre-commit CI check fails for licenseheaders. There are no pre-commit logs. However, I believe it is because it runs the licenseheaders hook on all files, not just the ones changed in this PR... Any suggestions on how to fix this? One solution is to run licenseheaders with the new template on all files. The licenseheaders hook in future PRs must pass, then. |
Signed-off-by: Håkon Wiik Ånes <[email protected]>
I decided to skip the licenseheaders check for now, but added a TODO comment to remove the skip at a later time when we're close to updating most files' headers with pre-commit and licenseheaders locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this, seems like an elegant way to tackle license headers.
Thanks for the review! I'll release over the weekend. |
Description of the change
Brings changes in develop into main for the 0.13.3 release. Planned release January 1.
Other changes:
row_stack()
withvstack()
(silence warnings)Regarding licenseheaders. I suggest the following new routine: Only update the license header year when a file is actually changed. This is handled by pre-commit. This means we won't change the year in all files once a year.
Progress of the PR
For reviewers
__init__.py
.section in
CHANGELOG.rst
.__credits__
inorix/__init__.py
and in.zenodo.json
.