Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.13.3 release #538

Merged
merged 23 commits into from
Jan 5, 2025
Merged

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented Dec 30, 2024

Description of the change

Brings changes in develop into main for the 0.13.3 release. Planned release January 1.

Other changes:

  • Replace use of NumPy deprecated row_stack() with vstack() (silence warnings)
  • Add licenseheaders template to pre-commit hooks.

Regarding licenseheaders. I suggest the following new routine: Only update the license header year when a file is actually changed. This is handled by pre-commit. This means we won't change the year in all files once a year.

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • Contributor(s) are listed correctly in __credits__ in orix/__init__.py and in
    .zenodo.json.

pc494 and others added 22 commits September 20, 2024 08:13
Relax space group requirement when creating phase from CIF
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
updates:
- [github.com/psf/black: 24.8.0 → 24.10.0](psf/black@24.8.0...24.10.0)
Avoid expensive deepcopy when rotating Miller
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
@hakonanes hakonanes added the dev Package maintenance label Dec 30, 2024
@hakonanes hakonanes added this to the v0.13.3 milestone Dec 30, 2024
@hakonanes hakonanes changed the base branch from develop to main December 30, 2024 17:48
@hakonanes hakonanes mentioned this pull request Dec 30, 2024
8 tasks
@hakonanes hakonanes requested a review from CSSFrancis January 1, 2025 09:27
@hakonanes
Copy link
Member Author

@CSSFrancis, the pre-commit CI check fails for licenseheaders. There are no pre-commit logs. However, I believe it is because it runs the licenseheaders hook on all files, not just the ones changed in this PR... Any suggestions on how to fix this?

One solution is to run licenseheaders with the new template on all files. The licenseheaders hook in future PRs must pass, then.

@hakonanes
Copy link
Member Author

I decided to skip the licenseheaders check for now, but added a TODO comment to remove the skip at a later time when we're close to updating most files' headers with pre-commit and licenseheaders locally.

Copy link
Member

@pc494 pc494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this, seems like an elegant way to tackle license headers.

@hakonanes
Copy link
Member Author

Thanks for the review! I'll release over the weekend.

@hakonanes hakonanes merged commit 6b94792 into pyxem:main Jan 5, 2025
12 checks passed
@hakonanes hakonanes deleted the prepare-0.13.3-release branch January 5, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Package maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants