Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove shard_runtime arg that the function doesn't take anymore #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove shard_runtime arg that the function doesn't take anymore #7

wants to merge 1 commit into from

Conversation

apengwin
Copy link

@apengwin apengwin commented May 1, 2017 •
edited
Loading

shard_runtime isn't in the function signature for lambda_executor and default _executor, so the example crashes.

See pywren/pywren@513dbb3

shivaram
shivaram reviewed May 1, 2017
View reviewed changes
Copy link

@shivaram shivaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @apengwin

@shivaram
Copy link

shivaram commented May 1, 2017

@ericmjonas @ooq we need to think about how to version the examples repo so it is backwards compatible ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivaram shivaram shivaram left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apengwin @shivaram