Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the distapcthing of a dataset (keeping the same filenames) #163

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

adybbroe
Copy link
Contributor

@adybbroe adybbroe commented Apr 11, 2023

This PR adds the possibility to dispatch datasets, A dataset is a set of files with uid's and full uri's. It splits the dataset in separate files and dispatch each file using the original file name and all files of the dataset is of course dispatched to the same destination.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@adybbroe
Copy link
Contributor Author

It says I should add my name to the AUTHORS.md but I don't see this file?

@adybbroe adybbroe self-assigned this Apr 11, 2023
@djhoese
Copy link
Member

djhoese commented Apr 11, 2023

The template was probably copied from satpy.

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #163 (7be9f1f) into main (4a4c8bc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   88.61%   88.61%           
=======================================
  Files          22       22           
  Lines        4425     4469   +44     
=======================================
+ Hits         3921     3960   +39     
- Misses        504      509    +5     
Flag Coverage Δ
unittests 88.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
trollmoves/dispatcher.py 94.46% <100.00%> (+0.37%) ⬆️
trollmoves/tests/conftest.py 100.00% <100.00%> (ø)
trollmoves/tests/test_dispatcher.py 99.22% <100.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adybbroe
Copy link
Contributor Author

The template was probably copied from satpy.

Yeah, thanks, that was also what I suspected.

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adybbroe adybbroe merged commit f7e52fe into pytroll:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants