Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize sftp mover #132

Merged
merged 8 commits into from
Oct 19, 2022
Merged

Modernize sftp mover #132

merged 8 commits into from
Oct 19, 2022

Conversation

mraspaud
Copy link
Member

This PR modernizes the sftp mover using paramiko's high level SSHClient.

  • Tests added

@mraspaud mraspaud self-assigned this Oct 19, 2022
@mraspaud mraspaud marked this pull request as ready for review October 19, 2022 09:03
@mraspaud mraspaud requested a review from pnuu as a code owner October 19, 2022 09:03
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #132 (4d696af) into main (662d86a) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   77.90%   77.83%   -0.08%     
==========================================
  Files          18       17       -1     
  Lines        4001     3731     -270     
==========================================
- Hits         3117     2904     -213     
+ Misses        884      827      -57     
Flag Coverage Δ
unittests 77.83% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
trollmoves/movers.py 82.89% <100.00%> (+9.65%) ⬆️
trollmoves/tests/test_movers.py 96.29% <100.00%> (+1.75%) ⬆️
trollmoves/dispatcher.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 820f45f into pytroll:main Oct 19, 2022
@mraspaud mraspaud deleted the fix-sftp-mover branch October 19, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants