Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove client listener callback #103

Merged
merged 4 commits into from
Nov 30, 2021

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Nov 29, 2021

In a continued effort to make Trollmoves easier to maintain, this PR removes the callback mechanism from the Client. In the same go, the unused trollmoves.client.StatCollector is removed.

  • Tests updated

@pnuu pnuu requested a review from mraspaud November 29, 2021 12:45
@pnuu pnuu self-assigned this Nov 29, 2021
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #103 (c8eea22) into main (3dd2584) will increase coverage by 0.22%.
The diff coverage is 97.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   76.88%   77.10%   +0.22%     
==========================================
  Files          18       18              
  Lines        3526     3508      -18     
==========================================
- Hits         2711     2705       -6     
+ Misses        815      803      -12     
Flag Coverage Δ
unittests 77.10% <97.59%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
trollmoves/client.py 72.26% <85.71%> (+0.85%) ⬆️
trollmoves/tests/test_client.py 99.53% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dd2584...c8eea22. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mraspaud mraspaud merged commit 80a856a into pytroll:main Nov 30, 2021
@pnuu pnuu deleted the refactor-remove-client-listener-callback branch November 30, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants