Add on-the-fly decompression to the AHI HSD reader #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrp84
requested review from
djhoese,
mraspaud and
sfinkens
as code owners
mraspaud
requested changes
Nov 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #984 +/- ##
==========================================
+ Coverage 86.86% 87.02% +0.16%
==========================================
Files 181 181
Lines 27461 27607 +146
==========================================
+ Hits 23854 24026 +172
+ Misses 3607 3581 -26
Continue to review full report at Codecov.
|
mraspaud
approved these changes
Nov 28, 2019
|
Note: This is NOT ready yet. Have discovered that the temp files are not being deleted. Will add + test a fix today. |
mraspaud
added
component:readers
enhancement
…2 if it is available on the system (much faster than bz2 for decompression).
… which(). Also simplify the code a little bit.
mraspaud
requested changes
Dec 6, 2019
…eeded brackets from if statements
mraspaud
approved these changes
Dec 6, 2019
|
This is still not ready to merge. @simonrp84 will add a test for the unzipping tool. |
…ed prior to attempting deletion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HSDformat data from Himawari/AHI typically comes in individual files compressed withbzip2.At present, satpy requires these files to be decompressed before passing them to the
Scenefunction. This PR enables on-the-fly decompression (using the same method as for thePPSfiles).I also replaced one unit test function (assertDictContainsSubset) that is deprecated.
flake8 satpy