Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compact viirs angle interpolation at the poles #901

Merged

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Sep 12, 2019

This PR fixes the wrong interpolation done at the poles for satellite and sun angles in the compact viirs reader.

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy

The effect was very local but led to a dramatic effect on some composites. The following figure exhibits the problem affecting the sun zenith:

Instab

It turns out it was probably due to some numerical instability. This is addressed now in the cartesian to angles conversion

@mraspaud mraspaud added this to the v0.17.0 milestone Sep 18, 2019
@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@34e4045). Click here to learn what that means.
The diff coverage is 51.51%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #901   +/-   ##
=========================================
  Coverage          ?   85.12%           
=========================================
  Files             ?      174           
  Lines             ?    25525           
  Branches          ?        0           
=========================================
  Hits              ?    21727           
  Misses            ?     3798           
  Partials          ?        0
Impacted Files Coverage Δ
satpy/tests/test_utils.py 98.84% <100%> (ø)
satpy/utils.py 70.76% <100%> (ø)
satpy/readers/viirs_compact.py 15.04% <11.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34e4045...66457df. Read the comment docs.

@mraspaud mraspaud merged commit 2010fcc into pytroll:master Sep 19, 2019
@mraspaud mraspaud deleted the fix-compact-viirs-pole-interpolation branch September 19, 2019 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant