-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factorize and improve modis reader's interpolation #802
Conversation
This avoids recomputation of parallel dataset that are anyway needed for the interpolation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these interpolation functions be delayed so that we aren't actually wasting memory by caching them?
From what I can see, the interpolation is dask-based, so I don't think a lot of memory is used |
Ah looks like you are right, nevermind then. LGTM. |
@mraspaud Is there anything else you are hoping to add to this PR or is it ready for review (it's still a draft currently)? |
It's ready for review now |
Any idea how we get the travis tests to start up? |
closing and reopening :( |
Codecov Report
@@ Coverage Diff @@
## master #802 +/- ##
==========================================
+ Coverage 82.26% 83.06% +0.79%
==========================================
Files 159 163 +4
Lines 22998 23592 +594
==========================================
+ Hits 18920 19596 +676
+ Misses 4078 3996 -82
Continue to review full report at Codecov.
|
This avoids recomputation of parallel datasets that are anyway needed for
the interpolation.
flake8 satpy