Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AVHRR tests importing external mock on Python 3 #763

Merged
merged 2 commits into from
May 17, 2019

Conversation

gerritholl
Copy link
Member

In the AVHRR L1B GACLAC testing routine, do not import mock from
external package when it can be successfully imported from the unittest
module.

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff

In the AVHRR L1B GACLAC testing routine, do not import mock from
external package when it can be successfully imported from the unittest
module.
Add an extra space character before inline comment to hopefully make
strickr-ci happy
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 81.813% when pulling 450ec28 on gerritholl:fix-import-mock into 7fe50a7 on pytroll:master.

@coveralls
Copy link

coveralls commented May 15, 2019

Coverage Status

Coverage decreased (-0.01%) to 81.831% when pulling 450ec28 on gerritholl:fix-import-mock into 7fe50a7 on pytroll:master.

@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #763 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
- Coverage   81.84%   81.83%   -0.02%     
==========================================
  Files         158      158              
  Lines       22728    22731       +3     
==========================================
  Hits        18601    18601              
- Misses       4127     4130       +3
Impacted Files Coverage Δ
satpy/tests/reader_tests/test_avhrr_l1b_gaclac.py 94.87% <50%> (-2.47%) ⬇️
satpy/scene.py 89.91% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe50a7...450ec28. Read the comment docs.

@djhoese djhoese changed the title Do not import mock on Python 3 Fix AVHRR tests importing external mock on Python 3 May 17, 2019
@djhoese djhoese added the bug label May 17, 2019
@djhoese djhoese self-assigned this May 17, 2019
@djhoese djhoese merged commit 1c32e24 into pytroll:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants