-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local caching of slicing for data reduction #635
Add local caching of slicing for data reduction #635
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this (the use of a reductions
dictionary) be cleaned up by using iter_by_area
or something similar? Could the reduction functionality shown here then be shared with the other similar methods like crop
and slice
? Maybe something like an iterated slicing/reducing method?
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
=========================================
+ Coverage 78.28% 78.3% +0.01%
=========================================
Files 136 136
Lines 19723 19735 +12
=========================================
+ Hits 15441 15453 +12
Misses 4282 4282
Continue to review full report at Codecov.
|
This PR avoids computing the slices for data reduction repeatedly when a bunch of datasets are resampled from the same area to the same area at the same time
git diff origin/master -- "*py" | flake8 --diff