Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clip negative FCI radiances #3013

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Improve reference data generation script.

2297ee7
Select commit
Loading
Failed to load commit list.
Open

Clip negative FCI radiances #3013

Improve reference data generation script.
2297ee7
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Dec 13, 2024 in 43s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.17 (10.00 -> 9.83)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Excess Number of Function Arguments image_comparison.py: step_when_generate_image

Annotations

Check warning on line 87 in satpy/tests/behave/features/steps/image_comparison.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments 

step_when_generate_image has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
View more details on CodeScene Delta Analysis