Correct Unexpected floats when reading LI L2 LFL #2998
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: -0.66 (8.31 -> 7.65)
- Declining Code Health: 6 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Large Method _li_test_utils.py: l2_lef_schema
- Large Method _li_test_utils.py: l2_lfl_schema
- Lines of Code in a Single File _li_test_utils.py
- Code Duplication _li_test_utils.py
- Large Method _li_test_utils.py: l2_le_schema
- Large Method _li_test_utils.py: l2_lgr_schema
✅ Improving Code Health:
- Low Cohesion _li_test_utils.py
Annotations
Check warning on line 1 in satpy/tests/reader_tests/_li_test_utils.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Lines of Code in a Single File
This module has 742 lines of code, improve code health by reducing it to 600. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check notice on line 1 in satpy/tests/reader_tests/_li_test_utils.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Low Cohesion
The number of different responsibilities decreases from 7 to 4, threshold = 4. Cohesion is calculated using the LCOM4 metric. Low cohesion means that the module/class has multiple unrelated responsibilities, doing too many things and breaking the Single Responsibility Principle.
Check warning on line 549 in satpy/tests/reader_tests/_li_test_utils.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Code Duplication
The module contains 3 functions with similar structure: l2_af_schema,l2_afa_schema,l2_afr_schema. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Check warning on line 270 in satpy/tests/reader_tests/_li_test_utils.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
l2_lef_schema increases from 122 to 126 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check warning on line 485 in satpy/tests/reader_tests/_li_test_utils.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
l2_lfl_schema increases from 107 to 112 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check warning on line 143 in satpy/tests/reader_tests/_li_test_utils.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
l2_le_schema increases from 85 to 103 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check warning on line 366 in satpy/tests/reader_tests/_li_test_utils.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Large Method
l2_lgr_schema has 89 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.