Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update oci l2 BGC file pattern, make netCDF version optional in the file ext format #2996

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yufeizhu600
Copy link
Contributor

@yufeizhu600 yufeizhu600 commented Nov 21, 2024

When I test the PACE OCI L2 BGC reader, I have found the file extension of the data product files I have downloaded from NASA Earthdata is .nc instead .nc4 as the file pattern definition in the oci_l2_bgc reader.
This PR make the netCDF version in the file pattern optional in the config file to deal with this scenario.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (fa56be5) to head (ad45b67).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2996   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files         377      377           
  Lines       55155    55155           
=======================================
  Hits        52997    52997           
  Misses       2158     2158           
Flag Coverage Δ
behaviourtests 3.94% <ø> (ø)
unittests 96.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11958130611

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.193%

Totals Coverage Status
Change from base Build 11936881763: 0.0%
Covered Lines: 53241
Relevant Lines: 55348

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants