Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing hatchling dependency to unstable CI #2813

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jun 12, 2024

Unstable is failing because hatchling isn't being installed. This should fix that.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese djhoese requested a review from mraspaud as a code owner June 12, 2024 15:36
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (ab55c4a) to head (3c7938c).
Report is 461 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2813      +/-   ##
==========================================
+ Coverage   95.91%   95.94%   +0.02%     
==========================================
  Files         366      366              
  Lines       53504    53504              
==========================================
+ Hits        51321    51332      +11     
+ Misses       2183     2172      -11     
Flag Coverage Δ
behaviourtests 4.04% <ø> (+<0.01%) ⬆️
unittests 96.03% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

It is pure python and rarely causes issues. It also has many dependencies not used by anything else.
@coveralls
Copy link

coveralls commented Jun 12, 2024

Pull Request Test Coverage Report for Build 9485875755

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.04%

Totals Coverage Status
Change from base Build 9418285216: 0.0%
Covered Lines: 51561
Relevant Lines: 53687

💛 - Coveralls

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this!

@mraspaud mraspaud merged commit e28e2ca into pytroll:main Jun 13, 2024
18 of 19 checks passed
@djhoese
Copy link
Member Author

djhoese commented Jun 14, 2024

@mraspaud @pnuu this is ready for review. The unstable environment now has "proper" failing tests. There are failures for numba which doesn't support numpy 2 yet, but also some unexpected failures and warnings. Mainly some h5netcdf close context manager failures or something and a lot of unexpected output dtypes in the DayNightCompositor tests. The numpy 2 dtype PR in xarray has been merged so I expected these to go away. We should look into these failures and make sure that it isn't a missed use case or something we should/can fix in Satpy. That said, I think this PR should be merged as-is so that other PRs can implement the fixes.

@djhoese
Copy link
Member Author

djhoese commented Jun 14, 2024

Haha, my open tab didn't refresh to show me that this was already merged many hours ago. Nevermind the review, thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants