-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing hatchling dependency to unstable CI #2813
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2813 +/- ##
==========================================
+ Coverage 95.91% 95.94% +0.02%
==========================================
Files 366 366
Lines 53504 53504
==========================================
+ Hits 51321 51332 +11
+ Misses 2183 2172 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It is pure python and rarely causes issues. It also has many dependencies not used by anything else.
Pull Request Test Coverage Report for Build 9485875755Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for fixing this!
@mraspaud @pnuu this is ready for review. The unstable environment now has "proper" failing tests. There are failures for numba which doesn't support numpy 2 yet, but also some unexpected failures and warnings. Mainly some h5netcdf |
Haha, my open tab didn't refresh to show me that this was already merged many hours ago. Nevermind the review, thanks for merging! |
Unstable is failing because hatchling isn't being installed. This should fix that.
AUTHORS.md
if not there already