Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netcdf4 to goci2 optional dependency in pyproject.toml #2799

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

Isotr0py
Copy link
Contributor

  • This PR adds goci2 optional dependency with netCDF4 >= 1.1.8 since we used NetCDF4FileHandler for GOCI2 reader.

@Isotr0py Isotr0py requested review from djhoese and mraspaud as code owners May 11, 2024 05:24
Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (1742616) to head (32df750).
Report is 529 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2799   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         379      379           
  Lines       53861    53861           
=======================================
  Hits        51680    51680           
  Misses       2181     2181           
Flag Coverage Δ
behaviourtests 4.09% <ø> (ø)
unittests 96.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9041420548

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.029%

Totals Coverage Status
Change from base Build 9020304102: 0.0%
Covered Lines: 51552
Relevant Lines: 53684

💛 - Coveralls

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit a812c55 into pytroll:main Jun 4, 2024
18 of 19 checks passed
@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Jun 4, 2024
@mraspaud mraspaud added this to the v0.49.0 milestone Jun 4, 2024
@Isotr0py Isotr0py deleted the goci2 branch June 4, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants