-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Sentinel-2 MSI sensor name to lowercase in the reader YAML config file and add support for "counts" calibration #2779
Convert Sentinel-2 MSI sensor name to lowercase in the reader YAML config file and add support for "counts" calibration #2779
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2779 +/- ##
=======================================
Coverage 95.92% 95.93%
=======================================
Files 377 377
Lines 53535 53541 +6
=======================================
+ Hits 51356 51362 +6
Misses 2179 2179
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 8721657075Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised the sensor is defined per dataset, but that's not your doing so don't worry about it. This looks good to me, but I'd like someone else who has more experience with this data hit the merge button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for making the counts available and making tests for it.
This PR has two purposes:
Inconsistent sensor/satellite input
in pyspectral since the latter one stores sensor name in lowercase. So it's replace by lowercase.