Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Sentinel-2 MSI sensor name to lowercase in the reader YAML config file and add support for "counts" calibration #2779

Merged
merged 7 commits into from
Apr 17, 2024
Merged

Conversation

yukaribbba
Copy link
Contributor

@yukaribbba yukaribbba commented Apr 13, 2024

This PR has two purposes:

  1. The current sensor name in YAML is "MSI", which triggers a minor warning Inconsistent sensor/satellite input in pyspectral since the latter one stores sensor name in lowercase. So it's replace by lowercase.
  2. Add "counts" calibration just like other sensors.

@yukaribbba yukaribbba requested a review from mraspaud as a code owner April 13, 2024 14:53
Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.93%. Comparing base (24109a1) to head (4faccbb).
Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2779   +/-   ##
=======================================
  Coverage   95.92%   95.93%           
=======================================
  Files         377      377           
  Lines       53535    53541    +6     
=======================================
+ Hits        51356    51362    +6     
  Misses       2179     2179           
Flag Coverage Δ
behaviourtests 4.10% <0.00%> (-0.01%) ⬇️
unittests 96.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Apr 13, 2024

Pull Request Test Coverage Report for Build 8721657075

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 8626996485: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised the sensor is defined per dataset, but that's not your doing so don't worry about it. This looks good to me, but I'd like someone else who has more experience with this data hit the merge button.

@mraspaud ?

@yukaribbba yukaribbba changed the title Convert Sentinel-2 MSI sensor name from uppercase to lowercase in the reader YAML config file Convert Sentinel-2 MSI sensor name to lowercase and add "counts" calibration in the reader YAML config file Apr 17, 2024
@yukaribbba yukaribbba changed the title Convert Sentinel-2 MSI sensor name to lowercase and add "counts" calibration in the reader YAML config file Convert Sentinel-2 MSI sensor name to lowercase in the reader YAML config file and add support for "counts" calibration Apr 17, 2024
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making the counts available and making tests for it.

@mraspaud mraspaud merged commit e7ccaa0 into pytroll:main Apr 17, 2024
18 of 19 checks passed
@yukaribbba yukaribbba deleted the convert_msi_name_to_lowercase branch April 17, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants