Add combined GRIB reader for both SEVIRI and FCI L2 products

[dnaviap]

Add combined GRIB reader that can be used for both SEVIRI and FCI L2 products.

• Tests added
• Fully documented
• Add @dnaviap to AUTHORS.md

[strandgren]

Thanks for working on this @dnaviap :) Before reviewing in more detail, I think we need some refactoring of the files:

1. Instead of having a eum_l2_grib.yaml files I suggest to keep the seviri_l2_grib.yaml file (which is still there) and add the FCI cloud mask dataset in a new fci_l2_grib.yaml file. That way we don't change the user interface to the reader. That's also how it's being done for the BUFR reader (Changes to Eumetsat L2 BUFR reader #2603)
2. eum_l2_grib.py should be compatible with both FCI and SEVIRI data, meaning that seviri_l2_grib.py should become obsolete and should therefore be removed.
3. Similarly, the new test file test_eum_l2_grib.py should make test_seviri_l2_grib.py obsolete, meaning it can be removed as well.

[dnaviap]

The refactoring is complete and tested.

[strandgren]

Thanks for the refactoring! :) See a couple of comments inline.

Can you please also modify the doc-string of the _scale_earth_axis method to read:

    def _scale_earth_axis(data):
        """Scale Earth axis data to make sure the value matched the expected unit [m].
        
        The earthMinorAxis value stored in the MPEF aerosol over sea product prior to December 12, 2022 has the wrong unit and this method provides a flexible work-around by making sure that all earth axis values are scaled such
        that they are on the order of millions of meters as expected by the reader. 
        
        """

That was a fix implemented by me a while ago when we noticed some issues in one of the products, and although it has been fixed in the product, the archived files will still have the issue meaning that the fix is still useful to have in the reader.

[dnaviap]

Thanks for the refactoring! :) See a couple of comments inline.

Can you please also modify the doc-string of the _scale_earth_axis method to read:

    def _scale_earth_axis(data):
        """Scale Earth axis data to make sure the value matched the expected unit [m].
        
        The earthMinorAxis value stored in the MPEF aerosol over sea product prior to December 12, 2022 has the wrong unit and this method provides a flexible work-around by making sure that all earth axis values are scaled such
        that they are on the order of millions of meters as expected by the reader. 
        
        """

That was a fix implemented by me a while ago when we noticed some issues in one of the products, and although it has been fixed in the product, the archived files will still have the issue meaning that the fix is still useful to have in the reader.

[strandgren]

Thanks for the fixes and the refactoring @dnaviap!

I left a couple of minor comments in-line. Could you please also merge the main branch into this branch and resolve the merge conflict such that all unit tests etc. run?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (b8991c0) to head (ba30733).
Report is 30 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2717   +/-   ##
=======================================
  Coverage   96.07%   96.08%           
=======================================
  Files         373      375    +2     
  Lines       54491    54578   +87     
=======================================
+ Hits        52352    52441   +89     
+ Misses       2139     2137    -2     

Flag	Coverage Δ
behaviourtests	3.98% <0.00%> (-0.01%)	⬇️
unittests	96.18% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coveralls]

Pull Request Test Coverage Report for Build 9743868855

Details

• 168 of 168 (100.0%) changed or added relevant lines in 5 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 96.056%

---

Totals
Change from base Build 9702977764:	0.01%
Covered Lines:	51732
Relevant Lines:	53856

---

💛 - Coveralls

[mraspaud]

Nice work, just a couple of comments and questions

[mraspaud]

I see a bit of mocking. In our experience this can lead to problems down the road, and nowadays, we prefer to write a synthetic testing file to tmp_path and work with that instead. Do you think this would be doable for this format?

[strandgren]

To be honest I don't know and I also don't have the time to look into it at this point. Would be grateful if we could tackle that in another PR in the future :)

[mraspaud]

Ok, should we make an issue about it then?

[strandgren]

Yes, would be a pity if we were to forget it 😃 I created an issue here: #2932

[strandgren]

pre-commit.ci autofix

[coveralls]

Pull Request Test Coverage Report for Build 11361065749

Details

• 168 of 168 (100.0%) changed or added relevant lines in 5 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 96.18%

---

Totals
Change from base Build 11324402105:	0.01%
Covered Lines:	52677
Relevant Lines:	54769

---

💛 - Coveralls

[mraspaud]

LGTM