Fix requiring newer numpy just for typing annotations #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraspaud
reviewed
Apr 22, 2021
|
Done |
Codecov Report
@@ Coverage Diff @@
## master #1649 +/- ##
==========================================
- Coverage 92.63% 92.62% -0.01%
==========================================
Files 258 258
Lines 37843 37847 +4
==========================================
+ Hits 35055 35057 +2
- Misses 2788 2790 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Works for me with (numpy 1.19.5). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
numpy.typingsubpackage was added in numpy 1.20 it seems. Satpy should still be able to support older versions of numpy. This PR adds a try/except around thenumpy.typingthat I added in #1646 for these older versions.