Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and deprecations #116

Merged
merged 1 commit into from
Oct 25, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions pygac/reader.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

Can't be used as is, has to be subclassed to add specific read functions.
"""
from abc import ABCMeta, abstractmethod, abstractproperty
from abc import ABCMeta, abstractmethod
import datetime
import logging
import numpy as np
Expand Down Expand Up @@ -591,12 +591,14 @@ def mask(self):
self._mask = self._get_corrupt_mask()
return self._mask

@abstractproperty
@property
@abstractmethod
def QFlag(self): # pragma: no cover
"""KLM/POD specific quality indicators."""
raise NotImplementedError

@abstractproperty
@property
@abstractmethod
def _quality_indicators_key(self): # pragma: no cover
raise NotImplementedError

Expand Down Expand Up @@ -779,12 +781,12 @@ def get_angles(self):
sat_azi: satellite azimuth angle degree clockwise from north in
range ]-180, 180]

sat_zentih: satellite zenith angles in degrees in range [0,90]
sat_zenith: satellite zenith angles in degrees in range [0,90]

sun_azi: sun azimuth angle degree clockwise from north in range
]-180, 180]

sun_zentih: sun zenith angles in degrees in range [0,90]
sun_zenith: sun zenith angles in degrees in range [0,90]

rel_azi: absolute azimuth angle difference in degrees between sun
and sensor in range [0, 180]
Expand Down Expand Up @@ -876,7 +878,7 @@ def correct_scan_line_numbers(self):
"""Remove scanlines with corrupted scanline numbers.

This includes:
- Scanline numbers outside the valide range
- Scanline numbers outside the valid range
- Scanline numbers deviating more than a certain threshold from the
ideal case (1,2,3,...N)

Expand Down Expand Up @@ -927,7 +929,7 @@ def correct_scan_line_numbers(self):
# Relatively small variation, keep (almost) everything
thresh = mean_nz_diffs + 3*std_nz_diffs
else:
# Large variation, filter more agressively. Use median and
# Large variation, filter more aggressively. Use median and
# median absolute deviation (MAD) as they are less sensitive to
# outliers. However, allow differences < 500 scanlines as they
# occur quite often.
Expand Down Expand Up @@ -1049,7 +1051,8 @@ def correct_times_thresh(self, max_diff_from_t0_head=6*60*1000,
results.update({'tn': tn, 'tcorr': self.utcs, 't0': t0})
return results

@abstractproperty
@property
@abstractmethod
def tsm_affected_intervals(self): # pragma: no cover
"""Specify time intervals being affected by the scan motor problem.

Expand Down