Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writer crashing on missing orbital parameters #107

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

sfinkens
Copy link
Member

This happens for older platforms (e.g. TIROS-N) if TLEs are missing.

@sfinkens sfinkens requested a review from mraspaud October 25, 2022 09:08
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud added the bug Something isn't working label Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #107 (da61c4c) into main (de38890) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   62.57%   62.57%           
=======================================
  Files           7        7           
  Lines         668      668           
=======================================
  Hits          418      418           
  Misses        250      250           
Impacted Files Coverage Δ
pygac_fdr/writer.py 89.04% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants