Convert to RGBA mode when opening the image for adding coastlines or rivers to file. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Any chance you can add a small test to make sure P gets converted to RGBA in the future ? |
|
I can try to add a test, yes! I'll try to have a look at it tomorrow. |
|
Could you also add something to the docstrings to mention that this conversion is going to happen? |
|
Docstrings updated and test added. I test only the addition of coastlines, since for testing also rivers, borders and grids we should add more shapefiles to the package: probably not necessary for the moment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff origin/develop **/*py | flake8 --diff