Misc changes to make torchax runnable on GPU. #8756
+194
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tags and stuff. Prepare for wheel upload.
qihqi
force-pushed
the
hanq_torchax_misc
branch
from
d6a21e4 to
f9671b2
Compare
qihqi
force-pushed
the
hanq_torchax_misc
branch
from
f9671b2 to
2f589a2
Compare
pgmoka
reviewed
Feb 27, 2025
.github/workflows/torch_xla2.yml
Outdated
| @@ -52,7 +51,7 @@ jobs: | |||
| pytest test/test_context.py | |||
| pytest test/test_train.py | |||
| pytest test/test_mutations.py | |||
| pytest test/test_tf_integration.py | |||
| # pytest test/test_tf_integration.py #TODO | |||
There was a problem hiding this comment.
Is there an issue we could track this in, and do a classic (TODO())
There was a problem hiding this comment.
done created a issue for this : #8770
pgmoka
reviewed
Feb 27, 2025
torchax/README.md
Outdated
|
|
||
| The following instructions assume you are in the `torchax` directory: | ||
| Finally install torchax |
There was a problem hiding this comment.
NIT: Unnecessary space at end of line
pgmoka
reviewed
Feb 27, 2025
There was a problem hiding this comment.
Does not need to be resolved here, but I think it is worth thinking for this README: let's say I am a new customer. In what cases should I use torchax rather than PyTorchXLA?
qihqi
force-pushed
the
hanq_torchax_misc
branch
from
cd15197 to
f514a18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tags and stuff, README update.