Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated typing for RandomErasing #8769

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ancestor-mithril
Copy link

torchvision.transforms.v2.RandomErasing accepts a float or a sequence of floats for value, which is also mentioned in the documentation.

Copy link

pytorch-bot bot commented Nov 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8769

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @ancestor-mithril!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@ancestor-mithril
Copy link
Author

Checks require approval from a maintainer.

@NicolasHug
Copy link
Member

Thanks for the PR @ancestor-mithril . I'm afraid this is introducing more issues: https://github.com/pytorch/vision/actions/runs/12088094679/job/33777630379?pr=8769

Note that a lot of typing annotations in torchvision are simply wrong, because they exist more to please torchscript than to please mypy (and those 2 tools often disagree).

@ancestor-mithril
Copy link
Author

Note that a lot of typing annotations in torchvision are simply wrong, because they exist more to please torchscript than to please mypy (and those 2 tools often disagree).

I see. Maybe adding a type hint to self.value will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants