Reapply "Fix memory leak in decode_webp (#8712)" (#8723)

[NicolasHug]

This reverts commit 7d077f1. which itself reverted #8710. So we're putting #8710 back

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8724

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 9 Unrelated Failures

As of commit 1e3822c with merge base cd839f1 ():

NEW FAILURES - The following jobs have failed:

• CMake / windows (windows.4xlarge, cpu) / windows-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/8724/merge
• Docs / build / linux-job (gh)
  RuntimeError: Command docker exec -t 9ab1ce4baca8ab7d3938d7155b7eca6474199d1ec9665d6bec5d9cd230f7e541 /exec failed with exit code 2
• Lint / python-types / linux-job (gh)
• Tests / unittests-windows (3.10, windows.4xlarge, cpu) / windows-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/8724/merge
• Tests / unittests-windows (3.11, windows.4xlarge, cpu) / windows-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/8724/merge
• Tests / unittests-windows (3.12, windows.4xlarge, cpu) / windows-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/8724/merge
• Tests / unittests-windows (3.9, windows.4xlarge, cpu) / windows-job (gh)
  ##[error]fatal: couldn't find remote ref refs/pull/8724/merge

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• Tests / unittests-linux (3.10, linux.12xlarge, cpu) / linux-job (gh) (trunk failure)
  test/test_ops.py::TestDeformConv::test_backward[0-True-cpu]
• Tests / unittests-linux (3.11, linux.12xlarge, cpu) / linux-job (gh) (trunk failure)
  test/test_ops.py::TestDeformConv::test_backward[0-True-cpu]
• Tests / unittests-linux (3.12, linux.12xlarge, cpu) / linux-job (gh) (trunk failure)
  test/test_ops.py::TestDeformConv::test_backward[0-True-cpu]
• Tests / unittests-linux (3.9, linux.12xlarge, cpu) / linux-job (gh) (trunk failure)
  test/test_ops.py::TestDeformConv::test_backward[0-True-cpu]
• Tests / unittests-linux (3.9, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh) (trunk failure)
  test/test_io.py::TestVideo::test_write_video_with_audio[cuda]
• Tests / unittests-macos (3.10, macos-m1-stable) / macos-job (gh) (trunk failure)
  test/test_io.py::TestVideo::test_write_video_with_audio[cpu]
• Tests / unittests-macos (3.12, macos-m1-stable) / macos-job (gh) (trunk failure)
  test/test_io.py::TestVideo::test_write_video_with_audio[cpu]
• Tests / unittests-macos (3.9, macos-m1-stable) / macos-job (gh) (trunk failure)
  test/test_io.py::TestVideo::test_write_video_with_audio[cpu]
• Tests / unittests-windows (3.9, windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh) (trunk failure)
  AttributeError: '_OpNamespace' 'image' object has no attribute '_jpeg_version'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[NicolasHug]

EDIT: Below is outdated. ROCm now works. No idea why it decided not to before. UGH.

---

Status as of 21ce0e7

• Build Windows Wheels / pytorch/vision / wheel-py3_9-xpu (pull_request) is failing with the same issue as on main
• Tests / unittests-windows (3.9, windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job - same
• Build Windows Wheels / pytorch/vision / wheel-py3_9-cuda11_8 (pull_request) and Build Windows Wheels / pytorch/vision / wheel-py3_9-cuda12_4 (pull_request) have been queued for days (same on main)
• rocm wheel jobs are failing during compilation with:

/__w/vision/vision/pytorch/vision/torchvision/csrc/io/image/cpu/decode_webp.cpp:50:42: error: ‘WebPFree’ was not declared in this scope
   50 |   auto deleter = [decoded_data](void*) { WebPFree(decoded_data); };
      |                                          ^~~~~~~~

Looking at the changelog of libwebp, WebPFree has been available at least before version 0.2 released in 2012 https://github.com/webmproject/libwebp/blob/4238bc0adbacf6d5021a6578e66332786ae6a5b6/ChangeLog#L512

So, for whatever reason, the libwebp that gets installed on rocm isn't recent enough, or just wrong. Either way, we can't block landing this because of a single platform, so we'll just not build with webp support on rocm. 🤷‍♂️

[NicolasHug]

Wheel jobs are green. Relevant unit-tests are passing. Existing failures are already visible on main. Landing.

[github-actions]

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py