Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with FFMPEG 7.0 #8408

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Conversation

eclipseo
Copy link
Contributor

@eclipseo eclipseo commented May 5, 2024

No description provided.

Copy link

pytorch-bot bot commented May 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8408

Note: Links to docs will display an error until the docs builds have been completed.

❌ 16 New Failures, 12 Unrelated Failures

As of commit d64420a with merge base a839642 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@eclipseo eclipseo force-pushed the fix_for_ffmpeg7 branch 4 times, most recently from a1f2a4b to 2312b39 Compare May 9, 2024 10:28
channel_layout has been replaced with ch_layout
@eclipseo eclipseo force-pushed the fix_for_ffmpeg7 branch from 2312b39 to 4a0853f Compare May 9, 2024 10:29
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @eclipseo . Our CI only compiles against ffmpeg4, all of the ffmpeg-related tests are unfortunately disabled #8162.

The compilation step of the jobs in this PR (with ffmpeg4) are running fine. I tried locally to compile and run some tests against ffmpeg7, which was successful.

Unfortunately, this is the best amount of testing we can provide for this right now...

Thanks a lot for the PR, I'll merge it now.

@NicolasHug NicolasHug merged commit 375cfdf into pytorch:main Jun 6, 2024
9 of 26 checks passed
facebook-github-bot pushed a commit that referenced this pull request Jun 7, 2024
Reviewed By: vmoens

Differential Revision: D58283813

fbshipit-source-id: 749e5c793d27ea87e3e12e1b3ecc146a40530067

Co-authored-by: Nicolas Hug <[email protected]>
Co-authored-by: Nicolas Hug <[email protected]>
Miriup pushed a commit to Miriup/torchvision-cuda-10.2 that referenced this pull request Dec 9, 2024
Co-authored-by: Nicolas Hug <[email protected]>
Co-authored-by: Nicolas Hug <[email protected]>
(cherry picked from commit 375cfdf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants