Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put back StanfordCars.download (the function, NOT the feature) #8324

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Mar 15, 2024

The download() method was removed in #8309 but since it's public it's best to keep it and raise the error there. Addresses #8309 (comment) which I missed - sorry

test:

[ins] In [1]: from torchvision.datasets import StanfordCars
[ins] In [2]: StanfordCars(root="/tmp", download=True)
         ...: 
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-2-a557e888a29e> in <module>
----> 1 StanfordCars(root="/tmp", download=True)

~/dev/vision/torchvision/datasets/stanford_cars.py in __init__(self, root, split, transform, target_transform, download)
     62 
     63         if download:
---> 64             self.download()
     65 
     66         if not self._check_exists():

~/dev/vision/torchvision/datasets/stanford_cars.py in download(self)
    102 
    103     def download(self):
--> 104         raise ValueError(
    105             "The original URL is broken so the StanfordCars dataset is not available for automatic "
    106             "download anymore. You can try to download it manually following "

ValueError: The original URL is broken so the StanfordCars dataset is not available for automatic download anymore. You can try to download it manually following https://github.com/pytorch/vision/issues/7545#issuecomment-1631441616, and set download=False to avoid this error.

@NicolasHug NicolasHug requested review from vfdev-5 and pmeier March 15, 2024 16:24
Copy link

pytorch-bot bot commented Mar 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8324

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 New Failures, 1 Pending, 23 Unrelated Failures

As of commit 8acff3b with merge base 4028d9f (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug NicolasHug merged commit ed4710b into pytorch:main Mar 17, 2024
1 check passed
@NicolasHug NicolasHug deleted the laefjnlaefnlajenf branch March 17, 2024 22:48
@NicolasHug NicolasHug added the other if you have no clue or if you will manually handle the PR in the release notes label Mar 17, 2024
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Mar 21, 2024
…e) (#8324)

Reviewed By: vmoens

Differential Revision: D55062768

fbshipit-source-id: b9a89b007572b8ba85b5eedefaff41275d535517
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed other if you have no clue or if you will manually handle the PR in the release notes
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

3 participants