Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix root path expansion in datasets.Kitti (#8163) #8164

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Fix root path expansion in datasets.Kitti (#8163) #8164

merged 1 commit into from
Dec 14, 2023

Conversation

fang-d
Copy link
Contributor

@fang-d fang-d commented Dec 14, 2023

This closes #8163.

cc @pmeier

Copy link

pytorch-bot bot commented Dec 14, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8164

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 54ab020 with merge base 44a9bea (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @fang-d!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@fang-d
Copy link
Contributor Author

fang-d commented Dec 14, 2023

I have already signed the Contributor License Agreement.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fang-d thanks a ton for the report and for the fix!

@NicolasHug NicolasHug merged commit 01dca0e into pytorch:main Dec 14, 2023
64 checks passed
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

NicolasHug pushed a commit to NicolasHug/vision that referenced this pull request Dec 14, 2023
@fang-d fang-d deleted the fang-d/fix-kitti-issue8163 branch December 14, 2023 12:10
facebook-github-bot pushed a commit that referenced this pull request Jan 16, 2024
Reviewed By: vmoens

Differential Revision: D52539002

fbshipit-source-id: 6f39af8ec0530a9533a14349901f26d273d18c59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in datasets.kitti.Kitti: expanduser operation not performed for root parameter
4 participants