Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing bracket #8117

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Add missing bracket #8117

merged 1 commit into from
Nov 14, 2023

Conversation

CptCaptain
Copy link
Contributor

@CptCaptain CptCaptain commented Nov 14, 2023

I've added a missing bracket to the docstring.

However, I was actually looking for the docs for this page, where it says in the parameters:
float (contrast tuple of) – How much to jitter contrast. contrast_factor is chosen uniformly from [min, max]. Should be non-negative numbers.
Obviously, there has been a mix-up.

I haven't been able to find the source for that page, maybe someone here knows how (or rather, where) to fix that.

cc @vfdev-5

Copy link

pytorch-bot bot commented Nov 14, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8117

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 8 Unrelated Failures

As of commit 13d8699 with merge base 9fa5f3f (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @CptCaptain!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @CptCaptain

@NicolasHug
Copy link
Member

NicolasHug commented Nov 14, 2023

I haven't been able to find the source for that page, maybe someone here knows how (or rather, where) to fix that.

The file you updated in this PR is the relevant one. I think sphinx was failing to parse the docs properly due to the missing parenthesis you added, but now everything will properly be fine - we'll be able to confirm soon when the docs finish building.

Make sure to go forward with the CLA so we can merge your PR :) !

@CptCaptain
Copy link
Contributor Author

Awesome, even better :)
I've signed the CLA, merge whenever you're ready.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@NicolasHug NicolasHug merged commit 4433680 into pytorch:main Nov 14, 2023
facebook-github-bot pushed a commit that referenced this pull request Nov 16, 2023
Reviewed By: vmoens

Differential Revision: D51391966

fbshipit-source-id: 8419fd9d861d65c515cd3d273c73dd73eb60b035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants